Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Cleaning up OIDC Work #3554

Merged
merged 12 commits into from
Nov 14, 2024
Merged

chore: Cleaning up OIDC Work #3554

merged 12 commits into from
Nov 14, 2024

Conversation

yhakbar
Copy link
Collaborator

@yhakbar yhakbar commented Nov 12, 2024

Description

Cleans up the work done to introduce --terragrunt-iam-web-identity-token.

Changes

  • Adds docs for the --terragrunt-iam-web-identity-token flag.
  • Fixes tests for the flag so that they run in CircleCI.
  • Integrates role assumption into the --terragrunt-auth-provider-cmd flag.

TODOs

Read the Gruntwork contribution guidelines.

  • Update the docs.
  • Run the relevant tests successfully, including pre-commit checks.
  • Ensure any 3rd party code adheres with our license policy or delete this line if its not applicable.
  • Include release notes. If this PR is backward incompatible, include a migration guide.

Release Notes (draft)

  • Updated --terragrunt-iam-web-identity-token.
  • Updated --terragrunt-auth-provider-cmd.

@yhakbar yhakbar force-pushed the chore/cleaning-up-oidc-work branch from a00862d to 7e5becb Compare November 12, 2024 22:27
@yhakbar yhakbar merged commit d5ed96d into main Nov 14, 2024
4 of 5 checks passed
@yhakbar yhakbar deleted the chore/cleaning-up-oidc-work branch November 14, 2024 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants