Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch build to Java 11 #102

Merged
merged 40 commits into from
Oct 8, 2019
Merged

Switch build to Java 11 #102

merged 40 commits into from
Oct 8, 2019

Conversation

badgerwithagun
Copy link
Member

@badgerwithagun badgerwithagun commented Dec 28, 2018

Fixes #113.

This PR will be kept working and up-to-date and merged when it's the right time to switch Orko entirely.

@badgerwithagun badgerwithagun changed the title Migrate to Java 11 Migrate to Java 11 [work in progress] Feb 5, 2019
@badgerwithagun
Copy link
Member Author

Many of these changes are gradually getting merged into master as version bumps to dependencies. Transition route:

  • Gradually reduce this down, via rebasing, to just the compiler and version changes
  • Enable CI for Java 11 (including E2E tests)
  • Stabilise for a while and wait for Java 11 to achieve stable state
  • Switch over

@badgerwithagun
Copy link
Member Author

Needs manual inclusion of the javax.activation and javax.bind libraries. See:

https://github.com/dropwizard/dropwizard/issues/2318

@badgerwithagun badgerwithagun changed the title Migrate to Java 11 [work in progress] Migrate to Java 11 [deferred] Feb 18, 2019
@badgerwithagun badgerwithagun changed the title Migrate to Java 11 [deferred] Migrate to Java 11 [WIP] Feb 18, 2019
@badgerwithagun
Copy link
Member Author

Should resolve this warning

@badgerwithagun badgerwithagun changed the title Migrate to Java 11 [WIP] Migrate to Java 11 [when Java 11 is considered stable] Apr 15, 2019
@badgerwithagun
Copy link
Member Author

Once #399 is in, it should be relatively easy to merge the code changes for this in and create a parallel Java 11 build on CircleCI so Java 11 support is maintained as part of the normal development train.

@badgerwithagun
Copy link
Member Author

I think the final trigger for this migration will be when dropwizard 2.0.0 drops. That will finally remove all the hacks necessary to get DW working on Java 11. I'm working on bringing the bulk of these changes into master now, barring the java 11 compiler requirement in the POM and CircleCI.

@badgerwithagun badgerwithagun changed the title Migrate to Java 11 [when Java 11 is considered stable] Switch build to Java 11 Aug 26, 2019
@badgerwithagun badgerwithagun merged commit 12f2c45 into master Oct 8, 2019
@badgerwithagun badgerwithagun deleted the java-11 branch October 8, 2019 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate to Java 11
1 participant