[EventEngine] Fix issues found when enabling event_engine_dns experiment in OSS
#35530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grpc-checks
bot
added
bloat/none
per-call-memory/neutral
per-call-memory/decrease
and removed
bloat/improvement
per-call-memory/decrease
per-call-memory/neutral
labels
grpc-checks
bot
added
per-call-memory/neutral
and removed
per-call-memory/decrease
labels
grpc-checks
bot
added
per-call-memory/increase
and removed
per-call-memory/neutral
labels
grpc-checks
bot
added
per-call-memory/neutral
and removed
per-call-memory/increase
labels
yijiem
force-pushed
the
enable-oss-ee-dns-posix
branch
from
62824ae to
010c853
Compare
grpc-checks
bot
added
per-call-memory/increase
and removed
per-call-memory/decrease
labels
drfloob
reviewed
Jan 18, 2024
grpc-checks
bot
added
per-call-memory/decrease
and removed
per-call-memory/increase
labels
drfloob
reviewed
Jan 19, 2024
drfloob
approved these changes
Jan 19, 2024
grpc-checks
bot
added
per-call-memory/neutral
per-call-memory/decrease
and removed
per-call-memory/decrease
per-call-memory/neutral
labels
grpc-checks
bot
added
per-call-memory/increase
and removed
per-call-memory/decrease
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
AF_UNSPECfor both IPv4 and IPv6 queries does not work in all cases. Specifically, forlocalhost:<>, c-ares only returns the IPv6 record i.e.::1.