[Aio] Graduation from experimental folder #23240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lidizheng
added
lang/Python
release notes: yes
|
The failed tests are due to an external Golang dependency breakage, not related to this PR. |
pfreixes
approved these changes
Jun 17, 2020
|
1 year of work! |
This was referenced Jun 21, 2020
lidizheng
force-pushed
the
aio-graduate
branch
from
d9e9908 to
5694b79
Compare
|
@gnossen PTAL. I've being watching asyncio related issues for recent releases and resolving them. The only major issue is the Windows polling mechanism incompatibility with 3.8+. From the first version with asyncio support in |
|
@lidizheng Sorry for the delay on this. Give me one more day to take a final look. |
|
Sure. Take your time. |
gnossen
approved these changes
Aug 18, 2020
|
@lidizheng @pfreixes Great work! This is a huge accomplishment! |
This was referenced Oct 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Progress: https://github.com/grpc/grpc/projects/16
Given current progress, gRPC AsyncIO stack passes interop tests, and reaches feature parity with sync stack. It's not perfect, and there could be unrevealed bugs. But we will continue watching issues and submitting code. The module should overall be mature enough to graduate from experimental.
This PR moves gRPC AsyncIO integration out of experimental folder, also ensures the public interfaces' backward compatibility is kept for
grpc.experimental.aio. Notedly, the private interfaces backward compatibility is broken by this PR. For example, import path ofgrpc.experimental.aio._metadata.Metadataneeds to be updated togrpc.aio._metadata.Metadata.Before we publish AsyncIO examples, I hope we can remove the "experimental" from the import path.