Make client args credentials and options optional
#512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the TypeScript generated clients require that `null` be passed to `credentials` and `options` if they're not being used. It's easier to simply make those arguments optional. I've left the `null` portion of the type though to maintain backwards compatibility.
|
Not sure why Kokoro still hasn't completed its checks... but otherwise this PR is ready for review. |
|
Yea I have to apply the tag for the kokoro test to run, and the reason I haven't applied the tag is because I thought we did this and reverted a long while ago and I forgot the reason now and I haven't got a chance to dig out the history. I might remember wrong. Will get to this asap. |
|
Gotcha. Thanks @stanley-cheung , no rush. |
|
@stanley-cheung I looked through the history of the master branch and found no evidence that those args were ever optional, outside of having been looser types in the past (i.e. |
stanley-cheung
approved these changes
Mar 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the TypeScript generated clients require that
nullbe passed tocredentialsandoptionsif they're not being used. It's easier to simply make those arguments optional. I've left thenullportion of the type though to maintain backwards compatibility.