Add streaming methods to PromiseClient

[juanjoDiaz]

Closes #300

[stanley-cheung]

Sorry, there seems to be some problem of the test suite reporting back the test result, but the tests suite did failed. Here are the relevant error logs:

ERROR in ./echo_grpc_web_pb.js 284:6
Module parse failed: Identifier 'methodInfo_ServerStreamingEcho' has already been declared (284:6)
You may need an appropriate loader to handle this file type.
|  *   !proto.grpc.gateway.testing.ServerStreamingEchoResponse>}
|  */
> const methodInfo_ServerStreamingEcho = new grpc.web.AbstractClientBase.MethodInfo(
|   proto.grpc.gateway.testing.ServerStreamingEchoResponse,
|   /** @param {!proto.grpc.gateway.testing.ServerStreamingEchoRequest} request */
 @ ./client.js 21:28-60
Service 'commonjs-client' failed to build: The command '/bin/sh -c cd $EXAMPLE_DIR/commonjs-example &&   npm install &&   npm link grpc-web &&   npx webpack &&   cp echotest.html /var/www/html &&   cp dist/main.js /var/www/html/dist' returned a non-zero code: 2

[juanjoDiaz]

Yeah. I modified my commit fixing that.

[juanjoDiaz]

node_modules/@types/node/index.d.ts(815,38): error TS2583: Cannot find name 'Set'. Do you need to change your target library? Try changing the `lib` compiler option to es2015 or later.
Service 'ts-client' failed to build: The command '/bin/sh -c cd $EXAMPLE_DIR/ts-example &&   npm install &&   npm link grpc-web &&   tsc &&   npx webpack &&   cp echotest.html /var/www/html &&   cp dist/main.js /var/www/html/dist' returned a non-zero code: 2

Not sure if that error is related to my PR since I haven't added any Set or done anything with Sets.

[juanjoDiaz]

The only Set usage I can find in the code base comes from third_party/closure-library/closure/goog/structs/set_test.js Maybe something has changed in that dependency?

[stanley-cheung]

Found this: DefinitelyTyped/DefinitelyTyped#29172

[stanley-cheung]

Looks like something recently changed. Probably I should add that "lib": ["es6"] thing and we can try rebasing this PR on top of that fix and try again. Stay tuned.

Thanks for the contribution!

[stanley-cheung]

The Set error should be fixed by #302. Once that's merged, please try rebasing this PR, thanks!

[stanley-cheung]

#302 is merged, please try rebasing this PR, thanks!

[juanjoDiaz]

Rebased!

[mitar]

I am not sure if this works. If I try to use a streaming method on a promise client, I get:

error TypeError: Cannot read property 'serverStreaming' of undefined
    at proto.CorePromiseClient.getResults (core_grpc_web_pb.js:157)

I think this.client_.serverStreaming should be changed to this.delegateClient_.client_.serverStreaming for promise client.

[mitar]

And also this.hostname_ should be changed to this.delegateClient_.hostname_.

[juanjoDiaz]

You are right!
I aimed for the smallest change and it was too small :)

I'll submit a fix.

[mitar]

Already done in #308.