Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect documentation for certificate verification on the server builder #882

Merged
merged 1 commit into from
Jul 7, 2020

Conversation

glbrntt
Copy link
Collaborator

@glbrntt glbrntt commented Jul 7, 2020

Motivation:

The server build incorrectly claimed that without manually calling
withTLS(certificateVerification:) that .fullVerification would be
used. The default is actually .none.

Modifications:

Change the documented default to .none.

Result:

Documentation is no longer incorrect.

…r builder

Motivation:

The server build incorrectly claimed that without manually calling
`withTLS(certificateVerification:)` that `.fullVerification` would be
used. The default is actually `.none`.

Modifications:

Change the documented default to `.none`.

Result:

Documentation is no longer incorrect.
@glbrntt glbrntt added documentation semver/none No version bump required. labels Jul 7, 2020
@glbrntt glbrntt requested a review from Lukasa July 7, 2020 13:09
@glbrntt glbrntt merged commit e461a84 into grpc:master Jul 7, 2020
@glbrntt glbrntt deleted the gb-doc-fixup branch July 7, 2020 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver/none No version bump required.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants