Add a script to generate a bundle of plugins for CocoaPods #872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: grpc#869 adds a plugin containing the protoc binaries for CocoaPods. It relies on having a zip of the binaries in the tagged release. Modifications: - Add a script to generate a zip of the protoc binaries. Result: We can generate a bundle of plugins which may be pulled in by a CocoaPod.
|
cc @Lutzifer |
|
Should this be another Makefile target? |
A script is fine; it'll only be run by me or @MrMage when we tag a release. |
|
Ah, thanks to the new Github design, I thought this was only an issue, not a PR 🙈 Good job! |
MrMage
approved these changes
Jul 3, 2020
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
#869 adds a plugin containing the
protoc binaries for CocoaPods. It relies on having a zip of the binaries
in the tagged release.
Modifications:
Result:
We can generate a bundle of plugins which may be pulled in by a
CocoaPod.
This change is