Turn Network{Implementation,Preference} enums into structs #866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glbrntt
added
kind/enhancement
Lukasa
requested changes
Jun 30, 2020
Motivation: Public enums are a pain for API evolution and there's no need for users to be able to exhaustively switch over `NetworkImplementation` and `NetworkPreference`. Modifications: - Turn both into structs backed by enums Result: More evolvable API.
glbrntt
force-pushed
the
gb-public-enum-network-impl
branch
from
4e250b0 to
7068629
Compare
|
ping @Lukasa |
Lukasa
approved these changes
Jul 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Public enums are a pain for API evolution and there's no need for users to
be able to exhaustively switch over
NetworkImplementationandNetworkPreference.Modifications:
Result:
More evolvable API.