Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update license check and generated code #858

Merged
merged 1 commit into from
Jun 25, 2020
Merged

Update license check and generated code #858

merged 1 commit into from
Jun 25, 2020

Conversation

glbrntt
Copy link
Collaborator

@glbrntt glbrntt commented Jun 25, 2020

Motivation:

SwiftProtobuf 1.9 has added an extra line to the headers of its
generated code, our license checker didn't like this.

The Makefile also does not specify Package.resolved as a depenendcy for
the SwiftProtobuf protoc plugin target so the plugin is not always
up-to-date.

Modifications:

  • Update the license checker to allow for the extra line
  • Allow the license checker to complete before exiting so that all
    invalid files are listed
  • Update the protoc-gen-swift Makefile target to depenend on
    Package.resolved
  • Regenerate code

Result:

Happier license checks.

@glbrntt
Update license check and generated code
80349d9 
Motivation:

SwiftProtobuf 1.9 has added an extra line to the headers of its
generated code, our license checker didn't like this.

The Makefile also does not specify Package.resolved as a depenendcy for
the SwiftProtobuf protoc plugin target so the plugin is not always
up-to-date.

Modifications:

- Update the license checker to allow for the extra line
- Allow the license checker to complete before exiting so that all
  invalid files are listed
- Update the protoc-gen-swift Makefile target to depenend on
  Package.resolved
- Regenerate code

Result:

Happier license checks.
@glbrntt glbrntt added nio 🔨 semver/patch No public API change. labels Jun 25, 2020
@glbrntt glbrntt requested a review from Lukasa June 25, 2020 09:37
@glbrntt glbrntt mentioned this pull request Jun 25, 2020
Merged
Lukasa
Lukasa approved these changes Jun 25, 2020
View reviewed changes
Copy link
Collaborator

@Lukasa Lukasa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, :shipit:

@glbrntt glbrntt merged commit 4be0ed1 into grpc:master Jun 25, 2020
@glbrntt glbrntt deleted the gb-fix-license-check branch June 25, 2020 10:49
@glbrntt glbrntt added semver/none No version bump required. and removed 🔨 semver/patch No public API change. labels Jul 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lukasa Lukasa Lukasa approved these changes

Assignees
No one assigned
Labels
semver/none No version bump required.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@glbrntt @Lukasa