-
Notifications
You must be signed in to change notification settings - Fork 420
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated Dependencies to use latest #828
Conversation
|
I believe this PR will be required for us to release another Pod. With the update to NIOHTTP2, there's a version conflict between dependencies giving a build error for |
Yeah and the Swift 5.0 Compiler is not happy about the changes... (https://travis-ci.org/github/grpc/grpc-swift/jobs/696149912) |
Huh, that's interesting. The errors are around the establishment and data transfer report accessing fields in the new NIO Transport Services. Those are guarded behind OS availability guards ( However, I think that in this case the CI build is testing 5.0 compiles not by using a recent Xcode in 5.0 mode but by using an old Xcode. In this case, 10.3, which shipped before macOS 10.15. This means it doesn't have the macOS 10.15 SDK and so literally doesn't know these symbols exist. Because availability guards don't affect the parse, just the notion of availability, we error out. @glbrntt is this testing environment reflective of an intended use case? Are we really saying that we'll support not just "compile in 5.0 mode" but also "compile with the old compiler"? |
No, 10.3 was the latest Xcode when we setup the CI, we just haven't changed it yet. |
Cool, we should do that then. 😁 |
hey @mRs-, could you rebase your changes? I've fixed the flaky test and updated the CI. |
Yep will do it 👍 |
The Tests are passing 🎉 All ready to go now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great stuff, thanks @mRs-
@Jake-Prickett would you mind doing the cocoapods release? |
@Jake-Prickett @MrMage has was updating the pods (CGRPCZlib is done) but is now blocked on NIOSSL which hasn't been updated yet; could you update when you a get a chance? |
This also adds the workaround in #822