Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Dependencies to use latest #828

Merged
merged 1 commit into from
Jun 10, 2020
Merged

Updated Dependencies to use latest #828

merged 1 commit into from
Jun 10, 2020

Conversation

mRs-
Copy link
Contributor

@mRs- mRs- commented Jun 8, 2020

This also adds the workaround in #822

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jun 8, 2020

CLA Check
The committers are authorized under a signed CLA.

@Jake-Prickett
Copy link
Contributor

I believe this PR will be required for us to release another Pod. With the update to NIOHTTP2, there's a version conflict between dependencies giving a build error for 1.0.0-alpha.13 Podspec validation.

@mRs-
Copy link
Contributor Author

mRs- commented Jun 9, 2020

Yeah and the Swift 5.0 Compiler is not happy about the changes... (https://travis-ci.org/github/grpc/grpc-swift/jobs/696149912)

@Lukasa
Copy link
Collaborator

Lukasa commented Jun 9, 2020

Huh, that's interesting.

The errors are around the establishment and data transfer report accessing fields in the new NIO Transport Services. Those are guarded behind OS availability guards (#available and @available), so this ought not to be a problem.

However, I think that in this case the CI build is testing 5.0 compiles not by using a recent Xcode in 5.0 mode but by using an old Xcode. In this case, 10.3, which shipped before macOS 10.15. This means it doesn't have the macOS 10.15 SDK and so literally doesn't know these symbols exist. Because availability guards don't affect the parse, just the notion of availability, we error out.

@glbrntt is this testing environment reflective of an intended use case? Are we really saying that we'll support not just "compile in 5.0 mode" but also "compile with the old compiler"?

@glbrntt
Copy link
Collaborator

glbrntt commented Jun 9, 2020

@glbrntt is this testing environment reflective of an intended use case? Are we really saying that we'll support not just "compile in 5.0 mode" but also "compile with the old compiler"?

No, 10.3 was the latest Xcode when we setup the CI, we just haven't changed it yet.

@Lukasa
Copy link
Collaborator

Lukasa commented Jun 9, 2020

Cool, we should do that then. 😁

@glbrntt
Copy link
Collaborator

glbrntt commented Jun 9, 2020

hey @mRs-, could you rebase your changes? I've fixed the flaky test and updated the CI.

@mRs-
Copy link
Contributor Author

mRs- commented Jun 9, 2020

Yep will do it 👍

@mRs-
Copy link
Contributor Author

mRs- commented Jun 9, 2020

The Tests are passing 🎉 All ready to go now

Copy link
Collaborator

@glbrntt glbrntt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff, thanks @mRs-

@glbrntt glbrntt merged commit 2717d12 into grpc:master Jun 10, 2020
@glbrntt
Copy link
Collaborator

glbrntt commented Jun 10, 2020

I believe this PR will be required for us to release another Pod. With the update to NIOHTTP2, there's a version conflict between dependencies giving a build error for 1.0.0-alpha.13 Podspec validation.

@Jake-Prickett would you mind doing the cocoapods release?

@glbrntt
Copy link
Collaborator

glbrntt commented Jun 10, 2020

@Jake-Prickett @MrMage has was updating the pods (CGRPCZlib is done) but is now blocked on NIOSSL which hasn't been updated yet; could you update when you a get a chance?

@glbrntt glbrntt added the 🔨 semver/patch No public API change. label Jun 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔨 semver/patch No public API change.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants