Run tests with TSAN where available, add macOS CI for Swift 5.2 #799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lukasa
approved these changes
May 15, 2020
|
Unsurprisingly TSAN found an issue that #798 should resolve. I'll try again once that's merged. |
MrMage
approved these changes
May 16, 2020
Motivation: We should run TSAN in tests. Modifications: - run TSAN by default; don't run TSAN for Swift 5.0 on Linux - add Xcode 11.4 to add CI for Swift 5.2 on macOS Result: Resolves grpc#757
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
We should run TSAN in tests.
Modifications:
Result:
Resolves #757
This change is