Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add ProtoPathModuleMappings to the plugin options list #797

Merged
merged 2 commits into from
May 14, 2020
Merged

docs: add ProtoPathModuleMappings to the plugin options list #797

merged 2 commits into from
May 14, 2020

Conversation

jagobagascon
Copy link
Contributor

Added ProtoPathModuleMappings to the plugin options with a link to the original docs from swift-protobuf.

closes #795

glbrntt
glbrntt approved these changes May 14, 2020
View reviewed changes
Copy link
Collaborator

@glbrntt glbrntt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks @jagobagascon

@glbrntt glbrntt merged commit 999dba3 into grpc:master May 14, 2020
@jagobagascon jagobagascon deleted the feature/add-ProtoPathModuleMappings-to-docs branch May 15, 2020 08:22
@glbrntt glbrntt added the 🔨 semver/patch No public API change. label Jun 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glbrntt glbrntt glbrntt approved these changes

Assignees
No one assigned
Labels
🔨 semver/patch No public API change.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

gen-grpc-swift: allow generating code in different modules
2 participants
@jagobagascon @glbrntt