Add Cocoapod Support for SwiftGRPC #764

Jake-Prickett · 2020-03-24T17:46:29Z

Added CGRPCZlib.podspec to enable the gRPC-Swift CocoaPod
- CGRPCZlib
Created gRPC-Swift.podspec 🎉
- gRPC-Swift
Added proper maintainers to both Pods
Added similar build_podspec script that will read from Package.resolved

linux-foundation-easycla · 2020-03-24T17:46:32Z

The committers are authorized under a signed CLA.

✅ Jake Prickett (4df061d)

glbrntt

Thanks @Jake-Prickett -- great start!

Would it be better to leverage something similar to what is done in SwiftNIO build_podspecs.sh?

Yes: I think it would make life easier in the long run.

Who would be the best people to add as Maintainers for the CGRPCZlib CocoaPod?

You (if you don't mind!), me, @MrMage and @Lukasa

The maintainers for the gRPC Swift CocoaPod should be the same.

CGRPCZlib.podspec

SwiftGRPC.podspec

SebastianThiebaud · 2020-04-03T23:12:30Z

I'm not sure this is related to this PR but the license file referenced in https://github.com/CocoaPods/Specs/blob/master/Specs/1/e/a/CGRPCZlib/1.0.0-alpha.11/CGRPCZlib.podspec.json is not right. It should be LICENSE, not LICENSE.txt.
Right now, Cocoapods is displaying warning messages when installing pods

[!] Unable to read the license file `LICENSE.txt` for the spec `CGRPCZlib (1.0.0-alpha.11)`

Thank you

Jake-Prickett · 2020-04-03T23:30:39Z

Good catch @SebastianThiebaud! I noticed the same thing when working through the Podspec Generation script. I've made the changes in script so it won't appear in the future and believe that should be fixed with the next release :)

SebastianThiebaud · 2020-04-03T23:31:52Z

Good catch @SebastianThiebaud! I noticed the same thing when working through the Podspec Generation script. I've made the changes in script so it won't appear in the future and believe that should be fixed with the next release :)

Awesome. That's what I thought, just wanted to make sure this script would also apply to CGRPCZlib. Thanks for the awesome work y'all! :)

glbrntt

Looks great @Jake-Prickett, there are a couple of minor issues to fix but I'm happy with it otherwise!

scripts/build_podspecs.py

MrMage · 2020-04-06T10:36:55Z

Do you plan to also add the resulting Podspec file to the repo? If so, should that be part of this PR?

Jake-Prickett · 2020-04-06T11:07:53Z

@glbrntt - Comments have been addressed, thank you for the review!

@MrMage - I was not planning on adding the Podspec file to the repository. The goal of the script is to generate the Podspec files (CGRPCZlib & gRPC-Swift) to a temp location when it is time for a release and push them. Any preference or thoughts? 😄

MrMage · 2020-04-06T11:44:20Z

@MrMage - I was not planning on adding the Podspec file to the repository. The goal of the script is to generate the Podspec files (CGRPCZlib & gRPC-Swift) to a temp location when it is time for a release and push them. Any preference or thoughts? 😄

I prefer to have the Podspec file in the repo. This is common practice among most packages, allows for quick inspection of the file by anyone, and having it in version control allows us to better review any changes to it.

glbrntt · 2020-04-06T12:04:14Z

@MrMage - I was not planning on adding the Podspec file to the repository. The goal of the script is to generate the Podspec files (CGRPCZlib & gRPC-Swift) to a temp location when it is time for a release and push them. Any preference or thoughts? 😄

I prefer to have the Podspec file in the repo. This is common practice among most packages, allows for quick inspection of the file by anyone, and having it in version control allows us to better review any changes to it.

I'm not opposed to having them checked in in addition to the script. To that end it would be useful if the script could take a path argument indicating where the podspecs should be generated.

Jake-Prickett · 2020-04-06T13:22:49Z

@MrMage @glbrntt That sounds like a fair middle ground. 👍 Added a path parameter (-p) to the build script that allows for the consumer to pass a desired path for Podspec generation. Additionally, if we do not provide a path, it will default to the cwd.

python scripts/build_podspecs.py 1.0.0-alpha.11

or

python scripts/build_podspecs.py -p . 1.0.0-alpha.11

glbrntt

Spotted a small bug which I missed last time around (it's been a while since I looked at Python...)

scripts/build_podspecs.py

mefilt · 2020-04-06T17:49:27Z

Hey every one. Me also need grps for cocoapods.
When will you approving pull request?
Can i help you?
Thx

Jake-Prickett · 2020-04-06T19:46:09Z

Hi @mefilt, the gRPC-Swift CocoaPod is available now if you would like to consume it. 👍

glbrntt

This is awesome; thanks for working on this @Jake-Prickett! Over to you @MrMage.

MrMage

Thank you for all the work that went into this!

Just nits; feel free to push back if you disagree with any of them.

MrMage · 2020-04-07T09:00:10Z

CGRPCZlib.podspec

+    s.module_name = 'CGRPCZlib'
+    s.version = '1.0.0-alpha.11'
+    s.license = { :type => 'Apache 2.0', :file => 'LICENSE' }
+    s.summary = 'Swift gRPC code generator plugin and runtime library'


Should CGRPCZlib have a different summary?

It can, I was thinking having something more generic that might fit both would keep the generation script simple. What do you think @MrMage? I'm open to either way 👍

Personally I would use a slightly different description for each, to avoid confusing anyone who looks up either package at the CocoaPods site. I understand that would need a bit of additional code, though.

I agree, that does make sense. Would you mind if I took that one up as a follow-up item and address it separately?

CGRPCZlib.podspec

scripts/build_podspecs.py

MrMage

No mandatory changes from my side; feel free to change the pod descriptions in a follow-up PR.

Leaving the merge to @glbrntt.

glbrntt requested changes Mar 25, 2020

View reviewed changes

MrMage mentioned this pull request Mar 27, 2020

Contribution for CocoaPods Support on NIO implementation #767

Closed

4 tasks

braddmiller mentioned this pull request Mar 27, 2020

Research Spike: Update to new GRPC SDK Electric-Coin-Company/zcash-swift-wallet-sdk#28

Closed

Jake-Prickett force-pushed the jake-prickett/grpc-swift-cocoapod-support branch 4 times, most recently from 15840a7 to 2d42af7 Compare March 27, 2020 19:40

Add Cocoapod Support for SwiftGRPC

cb338e8

Jake-Prickett force-pushed the jake-prickett/grpc-swift-cocoapod-support branch from 2d42af7 to cb338e8 Compare March 27, 2020 20:07

Jake-Prickett force-pushed the jake-prickett/grpc-swift-cocoapod-support branch 2 times, most recently from 0a0a00d to 4a7dd5e Compare April 3, 2020 20:53

Jake-Prickett requested review from glbrntt and MrMage April 3, 2020 20:55

Add build_podspec script

2741421

Jake-Prickett force-pushed the jake-prickett/grpc-swift-cocoapod-support branch from 4a7dd5e to 2741421 Compare April 4, 2020 13:04

glbrntt requested changes Apr 6, 2020

View reviewed changes

scripts/build_podspecs.py Outdated Show resolved Hide resolved

scripts/build_podspecs.py Outdated Show resolved Hide resolved

scripts/build_podspecs.py Show resolved Hide resolved

scripts/build_podspecs.py Outdated Show resolved Hide resolved

scripts/build_podspecs.py Show resolved Hide resolved

Script Comment Cleanup

8856c87

Update script to take in file path and add podspec files to repository

177dea2

Jake-Prickett force-pushed the jake-prickett/grpc-swift-cocoapod-support branch from 7dac322 to 177dea2 Compare April 6, 2020 13:18

Merge branch 'master' into jake-prickett/grpc-swift-cocoapod-support

04e73ad

Adjust comment

1cc3c6f

glbrntt requested changes Apr 6, 2020

View reviewed changes

scripts/build_podspecs.py Outdated Show resolved Hide resolved

Added fix for default param value

c20e596

glbrntt approved these changes Apr 7, 2020

View reviewed changes

MrMage reviewed Apr 7, 2020

View reviewed changes

Adjust quotation mark usage and deployment target

feb557a

Jake-Prickett force-pushed the jake-prickett/grpc-swift-cocoapod-support branch from a23777f to feb557a Compare April 7, 2020 12:38

MrMage approved these changes Apr 7, 2020

View reviewed changes

glbrntt merged commit 944c70a into grpc:master Apr 7, 2020

Jake-Prickett mentioned this pull request Apr 18, 2020

Provide Pod Specific Descriptions and Script Cleanup #775

Merged

Jake-Prickett deleted the jake-prickett/grpc-swift-cocoapod-support branch April 18, 2020 16:43

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Cocoapod Support for SwiftGRPC #764

Add Cocoapod Support for SwiftGRPC #764

Jake-Prickett commented Mar 24, 2020 •

edited

Loading

linux-foundation-easycla bot commented Mar 24, 2020 •

edited

Loading

glbrntt left a comment

SebastianThiebaud commented Apr 3, 2020

Jake-Prickett commented Apr 3, 2020

SebastianThiebaud commented Apr 3, 2020

glbrntt left a comment

MrMage commented Apr 6, 2020

Jake-Prickett commented Apr 6, 2020

MrMage commented Apr 6, 2020

glbrntt commented Apr 6, 2020

Jake-Prickett commented Apr 6, 2020

glbrntt left a comment

mefilt commented Apr 6, 2020

Jake-Prickett commented Apr 6, 2020

glbrntt left a comment

MrMage left a comment

MrMage Apr 7, 2020

Jake-Prickett Apr 7, 2020

MrMage Apr 7, 2020

Jake-Prickett Apr 7, 2020

MrMage left a comment

Add Cocoapod Support for SwiftGRPC #764

Add Cocoapod Support for SwiftGRPC #764

Conversation

Jake-Prickett commented Mar 24, 2020 • edited Loading

linux-foundation-easycla bot commented Mar 24, 2020 • edited Loading

glbrntt left a comment

Choose a reason for hiding this comment

SebastianThiebaud commented Apr 3, 2020

Jake-Prickett commented Apr 3, 2020

SebastianThiebaud commented Apr 3, 2020

glbrntt left a comment

Choose a reason for hiding this comment

MrMage commented Apr 6, 2020

Jake-Prickett commented Apr 6, 2020

MrMage commented Apr 6, 2020

glbrntt commented Apr 6, 2020

Jake-Prickett commented Apr 6, 2020

glbrntt left a comment

Choose a reason for hiding this comment

mefilt commented Apr 6, 2020

Jake-Prickett commented Apr 6, 2020

glbrntt left a comment

Choose a reason for hiding this comment

MrMage left a comment

Choose a reason for hiding this comment

MrMage Apr 7, 2020

Choose a reason for hiding this comment

Jake-Prickett Apr 7, 2020

Choose a reason for hiding this comment

MrMage Apr 7, 2020

Choose a reason for hiding this comment

Jake-Prickett Apr 7, 2020

Choose a reason for hiding this comment

MrMage left a comment

Choose a reason for hiding this comment

Jake-Prickett commented Mar 24, 2020 •

edited

Loading

linux-foundation-easycla bot commented Mar 24, 2020 •

edited

Loading