Remove required platforms from SPM #761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: We recently specified which platforms we supported in Package.swift based on what SwiftNIO supported. These minimum versions recently decreased making the platform requirement specification in Package.swift unnecessary. Modifications: - Remove platforms from Package.swift - Fix #file passed to function argument Result: - Dependents of gRPC Swift don't require their Package.swift to declare their supported platforms
Lukasa
approved these changes
Mar 24, 2020
|
What are the new platform requirements for SwiftNIO? I'm curious. |
|
They align with the defaults: macOS 10.10, oldest SDKs available in all Swift 5-supporting Xcodes for everything else. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
We recently specified which platforms we supported in Package.swift
based on what SwiftNIO supported. These minimum versions recently
decreased making the platform requirement specification in Package.swift
unnecessary.
Modifications:
Result:
their supported platforms