Rename generated clients from FooServiceClient to FooClient #736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @Davidde94 |
Davidde94
approved these changes
Mar 6, 2020
Motivation: Issue grpc#735 highlighted that the naming of generated clients is clunky. Let's improve it before the API is locked down. Note: it's possible to create a shim to create fix-its for this by creating a typealias from the old name to the new name, and then deprecating the typealias: ```swift @available(*, deprecated, renamed: "Echo_EchoClient") typealias Echo_EchoServiceClient = Echo_EchoClient ``` Modifications: - Update codegen - Regenerate clients and update usages Result: Generate clients have better names
glbrntt
force-pushed
the
gb-client-generator-renaming
branch
from
4184fcf to
8b04565
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Issue #735 highlighted that the naming of generated clients is clunky.
Let's improve it before the API is locked down.
Note: it's possible to create a shim to create fix-its for this by creating a
typealias from the old name to the new name, and then deprecating the
typealias:
Modifications:
Result:
Generate clients have better names