Support compression on the server #714
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrMage
reviewed
Jan 31, 2020
Sources/GRPCInteroperabilityTestsImplementation/InteroperabilityTestCases.swift
Outdated
Show resolved
Hide resolved
glbrntt
force-pushed
the
gb-compression-server
branch
2 times, most recently
from
542bc78 to
3290171
Compare
Motivation: We have compression on the client; we should support it on the server as well! Modifications: - Add server configuration to determine a preferred compression used for responses, and a list of compression algorithms enabled for requests. - Add options to disable compression for responses on the RPC context - Add an option to disable compression for a single response on the `sendResponse` method on the RPC context - Add interop tests. - Add a handful of other tests. Result: Server supports compression
glbrntt
force-pushed
the
gb-compression-server
branch
from
3290171 to
d943935
Compare
MrMage
approved these changes
Feb 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
We have compression on the client; we should support it on the server as
well!
Modifications:
responses, and a list of compression algorithms enabled for requests.
sendResponsemethod on the RPC contextResult:
Server supports compression