Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug with BoringSSLError.invalidSNIName exception #702

Merged
merged 3 commits into from
Jan 21, 2020
Merged

Fix bug with BoringSSLError.invalidSNIName exception #702

merged 3 commits into from
Jan 21, 2020

Conversation

esen
Copy link
Contributor

@esen esen commented Jan 17, 2020

When IP address is given as a host to ClientConnection BoringSSLError.invalidSNIName exception is thrown from NIOSSLClientHandler

This pull request fixes this by passing nil to NIOSSLClientHandler if serverHostname is an IP address

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jan 17, 2020 •
edited
Loading

CLA Check
The committers are authorized under a signed CLA.

glbrntt
glbrntt requested changes Jan 17, 2020
View reviewed changes
Copy link
Collaborator

@glbrntt glbrntt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this @esen - I've left some comments inline.

Sources/GRPC/ClientConnection.swift Show resolved Hide resolved
Sources/GRPC/ClientConnection.swift Outdated Show resolved Hide resolved
@esen esen requested review from glbrntt and MrMage January 17, 2020 18:41
@ealymbaev ealymbaev mentioned this pull request Jan 20, 2020
Closed
4 tasks
glbrntt
glbrntt approved these changes Jan 20, 2020
View reviewed changes
Copy link
Collaborator

@glbrntt glbrntt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks @esen!

MrMage
MrMage approved these changes Jan 20, 2020
View reviewed changes
Sources/GRPC/ClientConnection.swift Outdated Show resolved Hide resolved
@MrMage MrMage merged commit d19ae89 into grpc:nio Jan 21, 2020
@glbrntt glbrntt added the 🔨 semver/patch No public API change. label Feb 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glbrntt glbrntt glbrntt approved these changes

@MrMage MrMage MrMage approved these changes

Assignees
No one assigned
Labels
🔨 semver/patch No public API change.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@esen @MrMage @glbrntt