Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Swift 5.2 development snapshot. #698

Merged
merged 1 commit into from
Jan 15, 2020
Merged

Conversation

glbrntt
Copy link
Collaborator

@glbrntt glbrntt commented Jan 15, 2020

Motivation:

We should keep our pre-release swift builds up-to-date.

Modifications:

Update development snapshot to latest.

Result:

Up-to-date CI.

Motivation:

We should keep our pre-release swift builds up-to-date.

Modifications:

Update development snapshot to latest.

Result:

Up-to-date CI.
@glbrntt glbrntt requested a review from MrMage January 15, 2020 10:34
Copy link
Collaborator

@MrMage MrMage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we automatically use eg (today - 4 days)? Not sure if that's a good idea though.

@glbrntt
Copy link
Collaborator Author

glbrntt commented Jan 15, 2020

I think it'd be better to keep it to a period update - every week or so - then it's easier to tell if the toolchain is bad vs the PR.

@MrMage
Copy link
Collaborator

MrMage commented Jan 15, 2020

SGTM

@glbrntt glbrntt merged commit ebcd123 into grpc:nio Jan 15, 2020
@glbrntt glbrntt deleted the gb-update-ci branch January 15, 2020 10:45
@glbrntt glbrntt added the 🔨 semver/patch No public API change. label Feb 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔨 semver/patch No public API change.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants