Simplify compression representation. #688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: Since we don't support compression, there's no need for any scaffolding that we do have to be public. Moreover there's no need to over complicate something which isn't yet user facing. Modifications: Remove `CompressionMechanism` and replace it with `CompressionAlgorithm`; an enum containing all compression algorithms we support. At the moment this is limited to `identity`. Result: Simpler core, smaller public API.
MrMage
approved these changes
Jan 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Since we don't support compression, there's no need for any scaffolding
that we do have to be public. Moreover there's no need to over
complicate something which isn't yet user facing.
Modifications:
Remove
CompressionMechanismand replace it withCompressionAlgorithm; an enum containing all compression algorithms wesupport. At the moment this is limited to
identity.Result:
Simpler core, smaller public API.