Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make DelegatingErrorHandler underscored-internal #658

Merged
merged 2 commits into from
Dec 16, 2019
Merged

Make DelegatingErrorHandler underscored-internal #658

merged 2 commits into from
Dec 16, 2019

Conversation

glbrntt
Copy link
Collaborator

@glbrntt glbrntt commented Dec 16, 2019

See #657

@glbrntt glbrntt requested a review from MrMage December 16, 2019 12:09
MrMage
MrMage reviewed Dec 16, 2019
View reviewed changes
Copy link
Collaborator

@MrMage MrMage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, but what is this for, and where is it being used in a public context?

@glbrntt
Copy link
Collaborator Author

glbrntt commented Dec 16, 2019

This lives at the end of the client pipeline and closes the channel after any error but also calls any client error delegate.

It's only "public" for testing.

@MrMage
Copy link
Collaborator

MrMage commented Dec 16, 2019

Could we make it internal then and use it with @testable import?

@glbrntt glbrntt merged commit 73f380b into grpc:nio Dec 16, 2019
@glbrntt glbrntt deleted the gb-api-work-1 branch December 16, 2019 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MrMage MrMage MrMage approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@glbrntt @MrMage