Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix two memory leaks and update a link in the README. #501

Merged
merged 1 commit into from
Jul 5, 2019
Merged

Fix two memory leaks and update a link in the README. #501

merged 1 commit into from
Jul 5, 2019

Conversation

MrMage
Copy link
Collaborator

@MrMage MrMage commented Jul 3, 2019

Fixes #340.

@MrMage MrMage requested a review from rebello95 July 3, 2019 07:43
@MrMage MrMage closed this Jul 4, 2019
@MrMage MrMage reopened this Jul 4, 2019
@MrMage
Copy link
Collaborator Author

MrMage commented Jul 4, 2019

I think the CI failure is a flake. @rebello95, would you mind reviewing this PR?

@MrMage MrMage merged commit 7c9a83c into master Jul 5, 2019
@MrMage MrMage deleted the fix-leak branch July 16, 2019 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rebello95 rebello95 rebello95 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Memory Leak in ServiceClientBase.init(address:secure:arguments:)
2 participants
@MrMage @rebello95