Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Package.swift to use NIOHTTP2's nghttp2-support-branch. #393

Closed
wants to merge 1 commit into from
Closed

Update Package.swift to use NIOHTTP2's nghttp2-support-branch. #393

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions Package.resolved
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,17 +24,17 @@
"repositoryURL": "https://github.com/apple/swift-nio.git",
"state": {
"branch": null,
"revision": "98434c1f1d687ff5a24d2cabfbd19b5c7d2d7a2f",
"version": "1.13.0"
"revision": "87dbd0216c47ea2e7ddb1b545271b716e03b943e",
"version": "1.13.1"
}
},
{
"package": "swift-nio-http2",
"repositoryURL": "https://github.com/apple/swift-nio-http2.git",
"state": {
"branch": null,
"revision": "88bd6d369a729f88e63f53ae5265840de4bb1384",
"version": "0.2.1"
"branch": "nghttp2-support-branch",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Lukasa we should probably make a new release here

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense; given that that branch will only receive minor patches in the future, I think it would make sense to depend directly on the branch regardless?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MrMage I think that you cannot tag versions if you depend on anything by .branch(...).

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@weissi sorry, what do you mean with that?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MrMage IIRC, if you have a package foo that depends on another package bar using .branch("some-bar-branch"), then foo can never have a tagged version.
IIRC the failure happens if I build an executable package my-exec that depends on foo with some version (say from: "1.0.1") and the tagged 1.0.1 version depends on bar using .branch("some-bar-branch"), then my-exec won't compile.

Copy link
Contributor

@weissi weissi Mar 5, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MrMage the other way around works, yes. But what I described above does really not work, @aciidb0mb3r will know for sure and I think @tanner0101 does too?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MrMage I think the idea is that SemVer-wise it doesn't make sense to claim that you have a certain version if you're not restricting your dependency at all

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the elaboration! In that case, we can probably drop this PR and have you guys tag 0.2.2 instead.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MrMage let's wait for @aciidb0mb3r or @tannner0101 to confirm, they know better

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure whether or not you can do that, but you definitely shouldn't.

"revision": "86877eab84bc33cbc2a2fa4b522e3a2474b28cec",
"version": null
}
},
{
Expand Down
2 changes: 1 addition & 1 deletion Package.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ var packageDependencies: [Package.Dependency] = [
// Main SwiftNIO package
.package(url: "https://github.com/apple/swift-nio.git", .upToNextMajor(from: "1.12.0")),
// HTTP2 via SwiftNIO
.package(url: "https://github.com/apple/swift-nio-http2.git", .upToNextMinor(from: "0.2.1"))
.package(url: "https://github.com/apple/swift-nio-http2.git", .branch("nghttp2-support-branch"))
]

var cGRPCDependencies: [Target.Dependency] = []
Expand Down