Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Group DocC docs in the index page #2160

Merged
merged 2 commits into from
Jan 17, 2025
Merged

Group DocC docs in the index page #2160

merged 2 commits into from
Jan 17, 2025
+110 −4

Conversation

glbrntt
Copy link
Collaborator

@glbrntt glbrntt commented Jan 16, 2025

Motivation:

Grouping DocC docs by their area makes it easier to find things.

Modifications:

  • Group docs in the index page
  • Update various docs

Result:

Better docs

@glbrntt
Group DocC docs in the index page
010756b 
Motivation:

Grouping DocC docs by their area makes it easier to find things.

Modifications:

- Group docs in the index page
- Update various docs

Result:

Better docs
@glbrntt glbrntt requested a review from gjcairo January 16, 2025 10:44
@glbrntt glbrntt added the 🔨 semver/patch No public API change. label Jan 16, 2025
@glbrntt glbrntt enabled auto-merge (squash) January 16, 2025 10:45
gjcairo
gjcairo approved these changes Jan 16, 2025
View reviewed changes
Copy link
Collaborator

@gjcairo gjcairo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just left a comment which you will want to address if this gets merged after the interceptor changes.

Sources/GRPCCore/Documentation.docc/Documentation.md Show resolved Hide resolved
@gjcairo gjcairo disabled auto-merge January 16, 2025 20:36
@glbrntt glbrntt enabled auto-merge (squash) January 17, 2025 09:34
@glbrntt glbrntt merged commit a92a58b into grpc:main Jan 17, 2025
31 of 33 checks passed
@glbrntt glbrntt deleted the v2/more-docs branch January 17, 2025 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gjcairo gjcairo gjcairo approved these changes

Assignees
No one assigned
Labels
🔨 semver/patch No public API change.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@glbrntt @gjcairo