Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add reflection server example #2149

Merged
merged 5 commits into from
Dec 20, 2024
Merged

Add reflection server example #2149

merged 5 commits into from
Dec 20, 2024

Conversation

glbrntt
Copy link
Collaborator

@glbrntt glbrntt commented Dec 20, 2024

Motivation:

We've added back the reflection server; we should have an example of how
to use it.

Modifications:

  • Add a reflection server example
  • Split the echo service into a separate file in the echo example so that it can be symlinked from the reflection server

Result:

More examples

@glbrntt
Add reflection server example
4ae7044 
Motivation:

We've added back the reflection server; we should have an example of how
to use it.

Modifications:

Add a reflection server example

Result:

More examples
@glbrntt
add generated
f773505
@glbrntt
ignore pb files
50d5a64
@glbrntt glbrntt added the semver/none No version bump required. label Dec 20, 2024
@glbrntt glbrntt marked this pull request as ready for review December 20, 2024 14:51
@glbrntt glbrntt requested a review from gjcairo December 20, 2024 14:52
gjcairo
gjcairo approved these changes Dec 20, 2024
View reviewed changes
Copy link
Collaborator

@gjcairo gjcairo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one very tiny comment. Thanks George!

Examples/reflection-server/README.md Outdated Show resolved Hide resolved
@glbrntt glbrntt enabled auto-merge (squash) December 20, 2024 15:09
@glbrntt glbrntt merged commit 5be11cd into grpc:main Dec 20, 2024
31 of 33 checks passed
@glbrntt glbrntt deleted the v2/reflection branch December 20, 2024 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gjcairo gjcairo gjcairo approved these changes

Assignees
No one assigned
Labels
semver/none No version bump required.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@glbrntt @gjcairo