Use nested protocols #2132
Merged
Use nested protocols #2132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: The minimum Swift version we require supports protocols being declared within another type. This means that all protocols and types we generate for a service can be declared within the enum namespace for that service and we can remove the typealiases. Modifications: - Declare generated protocols within their enum namespace - Inline generated service descriptors Result: Simpler generated code
|
API breakage is a false positive, it's on package level API |
rnro
reviewed
Nov 27, 2024
| ) -> Self { | ||
| return VariableDescription( | ||
| accessModifier: accessModifier, | ||
| isStatic: true, | ||
| kind: .let, | ||
| left: .identifierPattern("descriptor"), | ||
| right: .identifier(.type(.serviceDescriptor)).dot(namespacedProperty) | ||
| right: .functionCall(.serviceDescriptor(literalFullyQualifiedService: name)) |
There was a problem hiding this comment.
The example has both package and service parameters on the right but the code doesn't seem to reflect that at least to my inexpert eye.
There was a problem hiding this comment.
You're absolutely right, I had an intermediary change which the docs were correct for, I just forgot to update them when I landed on the final change. Good spot!
FranzBusch
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
The minimum Swift version we require supports protocols being declared within another type. This means that all protocols and types we generate for a service can be declared within the enum namespace for that service and we can remove the typealiases.
Modifications:
Result:
Simpler generated code