Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unbounded variable from formatting script #2091

Merged
merged 1 commit into from
Oct 9, 2024

Conversation

gjcairo
Copy link
Collaborator

@gjcairo gjcairo commented Oct 8, 2024

The formatting script should print a helpful message when formatting check fails showing which command to run to fix it.
However, it fails to print this because it cannot find the THIS_SCRIPT env variable.

@gjcairo gjcairo added the 🔨 semver/patch No public API change. label Oct 8, 2024
@gjcairo gjcairo requested a review from glbrntt October 8, 2024 22:54
@glbrntt glbrntt merged commit 22d1b57 into grpc:main Oct 9, 2024
5 of 8 checks passed
@glbrntt glbrntt added semver/none No version bump required. and removed 🔨 semver/patch No public API change. labels Oct 9, 2024
@gjcairo gjcairo deleted the fix-format-script branch October 9, 2024 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver/none No version bump required.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants