Add check that generated code is up-to-date #2013
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: It's easy for checked in generated code to not be up-to-date. Modifications: - Add a script to check it's up-to-date and run it in CI - That CI job now requires the Swift 6 toolchain, so we now rely on swift-format from the toolchain - Also fixes casing issues in the genreate script Result: More guarantess that checked in code is up-to-date
glbrntt
commented
Aug 12, 2024
| @@ -119,7 +119,7 @@ function generate_reflection_service { | |||
| mv "$output_v1/reflection.grpc.swift" "$output_v1/reflection-v1.grpc.swift" | |||
|
|
|||
| local proto_v1alpha="$here/upstream/grpc/reflection/v1alpha/reflection.proto" | |||
| local output_v1alpha="$root/Sources/GRPCReflectionService/v1alpha" | |||
| local output_v1alpha="$root/Sources/GRPCReflectionService/v1Alpha" | |||
There was a problem hiding this comment.
FWIW this wasn't an issue on macOS as AFPS is case-insensitive by default.
gjcairo
approved these changes
Aug 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
It's easy for checked in generated code to not be up-to-date.
Modifications:
Result:
More guarantess that checked in code is up-to-date