Drop the '.txt' extension from reflection data #1731
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: Generated reflection data has a ".txt" extension. This isn't quite right as the contents is base64 encdoded data. Moreover the generated reflection data is intended as an implementation detail for the reflection service. Modifications: - Change the generated reflection data extension from ".grpc.reflection.txt" to ".grpc.reflection". - Fix a bug in the reflection server example where resources couldn't be loaded because no subdirectory was provided Result: Generated reflection data files don't have a ".txt" extension
FranzBusch
approved these changes
Dec 4, 2023
stefanadranca
approved these changes
Dec 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Generated reflection data has a ".txt" extension. This isn't quite right as the contents is base64 encdoded data. Moreover the generated reflection data is intended as an implementation detail for the reflection service.
Modifications:
Result:
Generated reflection data files don't have a ".txt" extension