Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added availability check for OS version in unit tests for temporary directory path #1709

Merged
merged 1 commit into from
Nov 6, 2023

Conversation

stefanadranca
Copy link
Collaborator

Added availability check for OS version in unit tests for getting the path of the temporary directory

Motivation:

The .path() version is available only on macOS 13.0 or newer, hence the Skywagon errors.

Modifications:

Checked availability for macOS 13.0 or newer for calling the .path() function and used the "/tmp" directory for the older versions.

Result:

After your change, what will change.

… path of the temporary directory

Motivation:

The .path() version is available only on macOS 13.0 or newer, hence the Skywagon errors.

Modifications:

Checked availability for macOS 13.0 or newer for calling the .path() function and
used the "/tmp" directory for the older versions.

Result:

After your change, what will change.
@stefanadranca stefanadranca requested a review from glbrntt November 6, 2023 10:14
@glbrntt glbrntt added the semver/none No version bump required. label Nov 6, 2023
@glbrntt glbrntt merged commit b52f944 into grpc:main Nov 6, 2023
11 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver/none No version bump required.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants