Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some missing Sendable annotations #1702

Merged
merged 1 commit into from
Nov 1, 2023
Merged

Conversation

glbrntt
Copy link
Collaborator

@glbrntt glbrntt commented Nov 1, 2023

Motivation:

The latest HTTP2 release added a number of senability annotations which now cause warnings in our internal code.

Modifications:

  • Add missing Sendable annotations

Result:

Fewer warnings

@glbrntt glbrntt added the 🔨 semver/patch No public API change. label Nov 1, 2023
@glbrntt glbrntt requested a review from gjcairo November 1, 2023 16:26
@glbrntt glbrntt enabled auto-merge (squash) November 1, 2023 16:26
Motivation:

The latest HTTP2 release added a number of senability annotations which
now cause warnings in our internal code.

Modifications:

- Add missing `Sendable` annotations

Result:

Fewer warnings
@glbrntt glbrntt merged commit b28658f into grpc:main Nov 1, 2023
@glbrntt glbrntt deleted the gb-sendable-h2 branch November 2, 2023 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔨 semver/patch No public API change.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants