-
Notifications
You must be signed in to change notification settings - Fork 420
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add RPCError and Status #1656
Merged
Merged
Add RPCError and Status #1656
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
/* | ||
* Copyright 2023, gRPC Authors All rights reserved. | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
|
||
// FIXME: placeholder. | ||
public typealias Metadata = [String: String] |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,244 @@ | ||
/* | ||
* Copyright 2023, gRPC Authors All rights reserved. | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
|
||
/// An error representing the outcome of an RPC. | ||
/// | ||
/// See also ``Status``. | ||
public struct RPCError: @unchecked Sendable, Hashable, Error { | ||
// @unchecked because it relies on heap allocated storage and 'isKnownUniquelyReferenced' | ||
|
||
private var storage: Storage | ||
private mutating func ensureStorageIsUnique() { | ||
if !isKnownUniquelyReferenced(&self.storage) { | ||
self.storage = self.storage.copy() | ||
} | ||
} | ||
|
||
/// A code representing the high-level domain of the error. | ||
public var code: Code { | ||
get { self.storage.code } | ||
set { | ||
self.ensureStorageIsUnique() | ||
self.storage.code = newValue | ||
} | ||
} | ||
|
||
/// A message providing additional context about the error. | ||
public var message: String { | ||
get { self.storage.message } | ||
set { | ||
self.ensureStorageIsUnique() | ||
self.storage.message = newValue | ||
} | ||
} | ||
|
||
/// Metadata associated with the error. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Couple of questions here:
|
||
/// | ||
/// Any metadata included in the error thrown from a service will be sent back to the client and | ||
/// conversely any ``RPCError`` received by the client may include metadata sent by a service. | ||
/// | ||
/// Note that clients and servers may synthesise errors which may not include metadata. | ||
public var metadata: Metadata { | ||
get { self.storage.metadata } | ||
set { | ||
self.ensureStorageIsUnique() | ||
self.storage.metadata = newValue | ||
} | ||
} | ||
|
||
/// Create a new RPC error. | ||
/// | ||
/// - Parameters: | ||
/// - code: The status code. | ||
/// - message: A message providing additional context about the code. | ||
/// - metadata: Any metadata to attach to the error. | ||
public init(code: Code, message: String, metadata: Metadata = [:]) { | ||
self.storage = Storage(code: code, message: message, metadata: metadata) | ||
} | ||
|
||
/// Create a new RPC error from the provided ``Status``. | ||
/// | ||
/// Returns `nil` if the provided ``Status`` has code ``Status/Code-swift.struct/ok``. | ||
/// | ||
/// - Parameter status: The status to convert. | ||
public init?(status: Status) { | ||
guard let code = Code(statusCode: status.code) else { return nil } | ||
self.init(code: code, message: status.message, metadata: [:]) | ||
} | ||
} | ||
|
||
extension RPCError: CustomStringConvertible { | ||
public var description: String { | ||
"\(self.code): \"\(self.message)\"" | ||
} | ||
} | ||
|
||
extension RPCError { | ||
private final class Storage: Hashable { | ||
var code: RPCError.Code | ||
var message: String | ||
var metadata: Metadata | ||
|
||
init(code: RPCError.Code, message: String, metadata: Metadata) { | ||
self.code = code | ||
self.message = message | ||
self.metadata = metadata | ||
} | ||
|
||
func copy() -> Self { | ||
Self(code: self.code, message: self.message, metadata: self.metadata) | ||
} | ||
|
||
func hash(into hasher: inout Hasher) { | ||
hasher.combine(self.code) | ||
hasher.combine(self.message) | ||
hasher.combine(self.metadata) | ||
} | ||
|
||
static func == (lhs: RPCError.Storage, rhs: RPCError.Storage) -> Bool { | ||
return lhs.code == rhs.code && lhs.message == rhs.message && lhs.metadata == rhs.metadata | ||
} | ||
} | ||
} | ||
|
||
extension RPCError { | ||
public struct Code: Hashable, Sendable, CustomStringConvertible { | ||
/// The numeric value of the error code. | ||
public var rawValue: Int { Int(self.wrapped.rawValue) } | ||
|
||
private var wrapped: Status.Code.Wrapped | ||
private init(_ wrapped: Status.Code.Wrapped) { | ||
self.wrapped = wrapped | ||
} | ||
|
||
internal init?(statusCode: Status.Code) { | ||
if statusCode == .ok { | ||
return nil | ||
} else { | ||
self.wrapped = statusCode.wrapped | ||
} | ||
} | ||
|
||
public var description: String { | ||
String(describing: self.wrapped) | ||
} | ||
} | ||
} | ||
|
||
extension RPCError.Code { | ||
/// The operation was cancelled (typically by the caller). | ||
public static let cancelled = Self(.cancelled) | ||
|
||
/// Unknown error. An example of where this error may be returned is if a | ||
/// Status value received from another address space belongs to an error-space | ||
/// that is not known in this address space. Also errors raised by APIs that | ||
/// do not return enough error information may be converted to this error. | ||
public static let unknown = Self(.unknown) | ||
|
||
/// Client specified an invalid argument. Note that this differs from | ||
/// ``failedPrecondition``. ``invalidArgument`` indicates arguments that are | ||
/// problematic regardless of the state of the system (e.g., a malformed file | ||
/// name). | ||
public static let invalidArgument = Self(.invalidArgument) | ||
|
||
/// Deadline expired before operation could complete. For operations that | ||
/// change the state of the system, this error may be returned even if the | ||
/// operation has completed successfully. For example, a successful response | ||
/// from a server could have been delayed long enough for the deadline to | ||
/// expire. | ||
public static let deadlineExceeded = Self(.deadlineExceeded) | ||
|
||
/// Some requested entity (e.g., file or directory) was not found. | ||
public static let notFound = Self(.notFound) | ||
|
||
/// Some entity that we attempted to create (e.g., file or directory) already | ||
/// exists. | ||
public static let alreadyExists = Self(.alreadyExists) | ||
|
||
/// The caller does not have permission to execute the specified operation. | ||
/// ``permissionDenied`` must not be used for rejections caused by exhausting | ||
/// some resource (use ``resourceExhausted`` instead for those errors). | ||
/// ``permissionDenied`` must not be used if the caller can not be identified | ||
/// (use ``unauthenticated`` instead for those errors). | ||
public static let permissionDenied = Self(.permissionDenied) | ||
|
||
/// Some resource has been exhausted, perhaps a per-user quota, or perhaps the | ||
/// entire file system is out of space. | ||
public static let resourceExhausted = Self(.resourceExhausted) | ||
|
||
/// Operation was rejected because the system is not in a state required for | ||
/// the operation's execution. For example, directory to be deleted may be | ||
/// non-empty, an rmdir operation is applied to a non-directory, etc. | ||
/// | ||
/// A litmus test that may help a service implementor in deciding | ||
/// between ``failedPrecondition``, ``aborted``, and ``unavailable``: | ||
/// - Use ``unavailable`` if the client can retry just the failing call. | ||
/// - Use ``aborted`` if the client should retry at a higher-level | ||
/// (e.g., restarting a read-modify-write sequence). | ||
/// - Use ``failedPrecondition`` if the client should not retry until | ||
/// the system state has been explicitly fixed. E.g., if an "rmdir" | ||
/// fails because the directory is non-empty, ``failedPrecondition`` | ||
/// should be returned since the client should not retry unless | ||
/// they have first fixed up the directory by deleting files from it. | ||
/// - Use ``failedPrecondition`` if the client performs conditional | ||
/// REST Get/Update/Delete on a resource and the resource on the | ||
/// server does not match the condition. E.g., conflicting | ||
/// read-modify-write on the same resource. | ||
public static let failedPrecondition = Self(.failedPrecondition) | ||
|
||
/// The operation was aborted, typically due to a concurrency issue like | ||
/// sequencer check failures, transaction aborts, etc. | ||
/// | ||
/// See litmus test above for deciding between ``failedPrecondition``, ``aborted``, | ||
/// and ``unavailable``. | ||
public static let aborted = Self(.aborted) | ||
|
||
/// Operation was attempted past the valid range. E.g., seeking or reading | ||
/// past end of file. | ||
/// | ||
/// Unlike ``invalidArgument``, this error indicates a problem that may be fixed | ||
/// if the system state changes. For example, a 32-bit file system will | ||
/// generate ``invalidArgument`` if asked to read at an offset that is not in the | ||
/// range [0,2^32-1], but it will generate ``outOfRange`` if asked to read from | ||
/// an offset past the current file size. | ||
/// | ||
/// There is a fair bit of overlap between ``failedPrecondition`` and | ||
/// ``outOfRange``. We recommend using ``outOfRange`` (the more specific error) | ||
/// when it applies so that callers who are iterating through a space can | ||
/// easily look for an ``outOfRange`` error to detect when they are done. | ||
public static let outOfRange = Self(.outOfRange) | ||
|
||
/// Operation is not implemented or not supported/enabled in this service. | ||
public static let unimplemented = Self(.unimplemented) | ||
|
||
/// Internal errors. Means some invariants expected by underlying System has | ||
/// been broken. If you see one of these errors, Something is very broken. | ||
public static let internalError = Self(.internalError) | ||
|
||
/// The service is currently unavailable. This is a most likely a transient | ||
/// condition and may be corrected by retrying with a backoff. | ||
/// | ||
/// See litmus test above for deciding between ``failedPrecondition``, ``aborted``, | ||
/// and ``unavailable``. | ||
public static let unavailable = Self(.unavailable) | ||
|
||
/// Unrecoverable data loss or corruption. | ||
public static let dataLoss = Self(.dataLoss) | ||
|
||
/// The request does not have valid authentication credentials for the | ||
/// operation. | ||
public static let unauthenticated = Self(.unauthenticated) | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add a comment why we use
@unchecked
here