Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Adopt h2handler multiplexer (#1587)" #1641

Merged
merged 2 commits into from
Aug 22, 2023

Conversation

glbrntt
Copy link
Collaborator

@glbrntt glbrntt commented Aug 21, 2023

This reverts commit 75b390e.

Some users have recently been hitting an "unreachable" state where we
try to close more streams than have been opened. This is hard to reproduce
but has bad consequences: a crash. We believe this change surfaced the bug
so are temporarily reverting it until it can be better characterised.

@glbrntt glbrntt added the 🔨 semver/patch No public API change. label Aug 21, 2023
@glbrntt glbrntt marked this pull request as ready for review August 21, 2023 15:29
@glbrntt glbrntt requested a review from Lukasa August 21, 2023 15:53
@glbrntt glbrntt merged commit 2828ee7 into grpc:main Aug 22, 2023
@glbrntt glbrntt deleted the gb-revert-75b390e9 branch August 22, 2023 07:53
WendellXY pushed a commit to sundayfun/grpc-swift that referenced this pull request Aug 24, 2023
pinlin168 pushed a commit to sundayfun/grpc-swift that referenced this pull request Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔨 semver/patch No public API change.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants