Only schedule a close if the ping was actually sent #1626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
1 similar comment
|
|
|
@marhas -- thanks for the PR. I'll need you to fix up your CLA before I can review this though. |
|
Hello George,
I believe I already have:

Is there anything else I need to do?
Thanks,
Marcel
… On 5 Jul 2023, at 14:32, George Barnett ***@***.***> wrote:
@marhas <https://github.com/marhas> -- thanks for the PR. I'll need you to fix up your CLA before I can review this though.
—
Reply to this email directly, view it on GitHub <#1626 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAQM23QBURZJMZW67XITAQTXOVNEJANCNFSM6AAAAAAZ6WNX4U>.
You are receiving this because you were mentioned.
|
|
Oh sorry my mistake; the bot usually updates the comment when the issue is resolved but I see the check has passed. |
glbrntt
approved these changes
Jul 5, 2023
|
Thanks for reviewing and merging it so quickly! |
WendellXY
pushed a commit
to sundayfun/grpc-swift
that referenced
this pull request
Aug 24, 2023
Co-authored-by: George Barnett <[email protected]>
pinlin168
pushed a commit
to sundayfun/grpc-swift
that referenced
this pull request
Aug 24, 2023
Co-authored-by: George Barnett <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an outbound ping is blocked, I believe we should not schedule a close of the connection.
For me this caused intermittent issues with "unavailable (14): Transport became inactive" when calling the same streaming endpoint repeatedly. The last outbound ping would be blocked by shouldBlockPing because the stream had closed, but a closeConnection call is still scheduled, potentially closing the connection of a consecutive call when fired.