Emit 'swift-format-ignore-file' in generated files to avoid having them reformatted by swift-format #1606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
glbrntt
reviewed
May 31, 2023
There was a problem hiding this comment.
Thanks @smikhanov.
Looks like this is failing the copyright header check, I think you'll need to update
grpc-swift/scripts/license-check.sh
Line 100 in 6b55ce0
drop_first=9.
smikhanov
force-pushed
the
disabling-swift-format-in-generated-code
branch
2 times, most recently
from
cbbdaf6 to
7ee2c06
Compare
…em reformatted by swift-format
smikhanov
force-pushed
the
disabling-swift-format-in-generated-code
branch
from
7ee2c06 to
dcf42e9
Compare
glbrntt
approved these changes
May 31, 2023
WendellXY
pushed a commit
to sundayfun/grpc-swift
that referenced
this pull request
Aug 24, 2023
…em reformatted by swift-format (grpc#1606)
pinlin168
pushed a commit
to sundayfun/grpc-swift
that referenced
this pull request
Aug 24, 2023
…em reformatted by swift-format (grpc#1606)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generator now emits a comment line in the generated code disabling processing of the generated file by the
swift-formatformatter. This is to allow checking in generated files into codebases that are regularly linted and reformatted usingswift-format, without generating a change in generated files every time listing is done.