Expose closeFuture in server interceptor context #1553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: Server calls expose a `closeFuture` where users can register callbacks to tear things down when the RPC ends. Interceptors don't have this capability and must rely on observing an `.end`. Modifications: Expose the `closeFuture` from `ServerCallContext` to the `ServerInterceptorContext`. Result: - Users can be notified in interceptors when the call ends. - Resolves grpc#1552
FranzBusch
approved these changes
Jan 11, 2023
WendellXY
pushed a commit
to sundayfun/grpc-swift
that referenced
this pull request
Aug 24, 2023
Motivation: Server calls expose a `closeFuture` where users can register callbacks to tear things down when the RPC ends. Interceptors don't have this capability and must rely on observing an `.end`. Modifications: Expose the `closeFuture` from `ServerCallContext` to the `ServerInterceptorContext`. Result: - Users can be notified in interceptors when the call ends. - Resolves grpc#1552
pinlin168
pushed a commit
to sundayfun/grpc-swift
that referenced
this pull request
Aug 24, 2023
Motivation: Server calls expose a `closeFuture` where users can register callbacks to tear things down when the RPC ends. Interceptors don't have this capability and must rely on observing an `.end`. Modifications: Expose the `closeFuture` from `ServerCallContext` to the `ServerInterceptorContext`. Result: - Users can be notified in interceptors when the call ends. - Resolves grpc#1552
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Server calls expose a
closeFuturewhere users can register callbacks to tear things down when the RPC ends. Interceptors don't have this capability and must rely on observing an.end.Modifications:
Expose the
closeFuturefromServerCallContextto theServerInterceptorContext.Result: