Adopt NIOAsyncSequenceProducer in grpc-swift #1477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glbrntt
reviewed
Sep 6, 2022
FranzBusch
reviewed
Sep 6, 2022
gjcairo
force-pushed
the
async-seq
branch
2 times, most recently
from
f73b406 to
22c2078
Compare
|
Performance tests on 5.6 and 5.7 are failing but they're related to the change of |
|
Will send follow-up CR to fix the allocation test failures - turns out we've willingly increased the number of allocations in |
FranzBusch
approved these changes
Sep 13, 2022
gjcairo
force-pushed
the
async-seq
branch
2 times, most recently
from
41047d5 to
534f80d
Compare
We want to make use of `NIOAsyncSequenceProducer` (or its throwing counterpart) instead of using `PassthroughMessageSequence` and `PassthroughMessageSource`. * Replaced usages of `PassthroughMessageSequence` and `PassthroughMessageSource` with `NIOThrowingAsyncSequenceProducer` grpc-swift now uses `NIOAsyncSequenceProducer`
glbrntt
approved these changes
Sep 27, 2022
glbrntt
added
🔨 semver/patch
WendellXY
pushed a commit
to sundayfun/grpc-swift
that referenced
this pull request
Aug 24, 2023
We want to make use of `NIOAsyncSequenceProducer` (or its throwing counterpart) instead of using `PassthroughMessageSequence` and `PassthroughMessageSource`. * Replaced usages of `PassthroughMessageSequence` and `PassthroughMessageSource` with `NIOThrowingAsyncSequenceProducer` grpc-swift now uses `NIOAsyncSequenceProducer`
pinlin168
pushed a commit
to sundayfun/grpc-swift
that referenced
this pull request
Aug 24, 2023
We want to make use of `NIOAsyncSequenceProducer` (or its throwing counterpart) instead of using `PassthroughMessageSequence` and `PassthroughMessageSource`. * Replaced usages of `PassthroughMessageSequence` and `PassthroughMessageSource` with `NIOThrowingAsyncSequenceProducer` grpc-swift now uses `NIOAsyncSequenceProducer`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We want to make use of
NIOAsyncSequenceProducer(or its throwing counterpart) instead of usingPassthroughMessageSequenceandPassthroughMessageSource.Modifications
PassthroughMessageSequenceandPassthroughMessageSourcewithNIOThrowingAsyncSequenceProducerResult
grpc-swift now uses
NIOAsyncSequenceProducer