Add missing 'Sendable' conformance #1404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: Sendable conformance was missing in a handful of places which generates warnings in newer toolchains. Modifications: - Make client calls Sendable - Client call wrappers should require Sendable types (this was implicitly enfored by calls requiring request and response types to be Sendable). This also requires the async sequence of requests to be Sendable for calls where requests are streamed which required a codegen change. - Make the various gRPC async sequence types conditionally Sendable Result: Fewer warnings
glbrntt
force-pushed
the
gb-sendable-fixes
branch
from
235c68f to
59b0839
Compare
Lukasa
approved these changes
May 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Sendable conformance was missing in a handful of places which generates
warnings in newer toolchains.
Modifications:
implicitly enfored by calls requiring request and response types to be
Sendable). This also requires the async sequence of requests to be
Sendable for calls where requests are streamed which required a
codegen change.
Result:
Fewer warnings