Reformat async code #1383
Merged
Reformat async code #1383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: We need to use a newer version of SwiftFormat on the async/await code. First we should update main so that merging changes into the async branch is cleaner. Modifications: - Update SwiftFormat - Reformat Result: Our version of SwiftFormat is new enough to correctly handle async/await code. (cherry picked from commit 80055e5)
Motivation: On 'main' we updated SwiftFormat to a version which knows about language features introduced in 5.5 and formatted the code accordingly. We need to do the same on the async branch. Modifications: - Remove rules to temporarily disable SwiftFormat (in place for compatibility reasons) - Rerun the formatter Result: Formatter is happy.
Lukasa
approved these changes
Apr 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.