Raise minimum Swift version for async/await #1379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: The latest 5.5 Swift compiler is not too pleased with some of the `Sendable` annotations which causes the compiler to crash. This is fixed in 5.6. Given we haven't released this to 'main' yet and Swift 5.6 has been around for a little while we should just raise the minimum Swift version which supports async/await. Modifications: - Raise the minimum Swift version for async/await to 5.6. Result: Compiler is happier.
FranzBusch
approved these changes
Mar 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
The latest 5.5 Swift compiler is not too pleased with some of the
Sendableannotations which causes the compiler to crash. This is fixedin 5.6. Given we haven't released this to 'main' yet and Swift 5.6 has
been around for a little while we should just raise the minimum Swift
version which supports async/await.
Modifications:
Result:
Compiler is happier.