Add Sendable conformance to core async/await API #1378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glbrntt
force-pushed
the
sendable
branch
3 times, most recently
from
9d68108 to
32e25ce
Compare
FranzBusch
approved these changes
Mar 30, 2022
Motivation: The core async/await API should have appropriate 'Sendable' conformance before we publish it to main. This change adds it to the core parts of the new API. There are still numerous types which can be made 'Sendable' but are either less significant (e.g. configuration) or require depdendencies to adopt 'Sendable' first (and would otherwise require `@preconcurrency`) Modifications: - Require swift-protobuf to be at least 1.19.0 (as 1.19.0 introduced `Sendable` to generated messages) - Regenerate examples etc. - Add `GRPCSendable` to ease adoption - Make some plain-old-data types `Sendable` including `GRPCStatus` - Require `Request` and `Response` to be `Sendable` in the client and server async APIs - Make the async server context `@unchecked Sendable` - Make the async writer and stream reader `Sendable` Result: Core async API is `Sendable`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
The core async/await API should have appropriate 'Sendable' conformance
before we publish it to main. This change adds it to the core parts of
the new API.
There are still numerous types which can be made 'Sendable' but are
either less significant (e.g. configuration) or require depdendencies to
adopt 'Sendable' first (and would otherwise require
@preconcurrency)Modifications:
GRPCSendableto ease adoptionSendableincludingGRPCStatusRequestandResponseto beSendablein the client andserver async APIs
@unchecked SendableSendableResult:
Core async API is
Sendable.