Ignore state machine inputs in unexpected states #1374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: When we ratchet down the last stream ID in a GOAWAY frame, we should only do it if we're quiescing. If we aren't quiescing then we should just ignore the request to do it. Modifications: - Ignore requests to ratchet down the last stream ID in a GOAWAY if we're not quiescing. Result: Fewer traps.
|
Allocation limits are incorrect because of the recent NIO release. Should be fixed by #1375 |
bimawa
pushed a commit
to StreamLayer/grpc-swift
that referenced
this pull request
Jun 17, 2022
Motivation: When we ratchet down the last stream ID in a GOAWAY frame, we should only do it if we're quiescing. If we aren't quiescing then we should just ignore the request to do it. Modifications: - Ignore requests to ratchet down the last stream ID in a GOAWAY if we're not quiescing. Result: Fewer traps.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
When we ratchet down the last stream ID in a GOAWAY frame, we should
only do it if we're quiescing. If we aren't quiescing then we should
just ignore the request to do it.
Modifications:
we're not quiescing.
Result:
Fewer traps.