gPRC swift protobuf easy installation + easy file generataions #1318

El-Moatasem · 2021-11-24T11:51:43Z

Adding Easy Installation Using Homebrew Package
Adding Automatic Files Generation Script in Build Phases Xcode

…PC-Swift" on Mac OS Machine

linux-foundation-easycla · 2021-11-24T11:51:48Z

The committers are authorized under a signed CLA.

✅ El Moatasem Madani (6d7bfc1, 7a91688)

glbrntt

Thanks for your patch @El-Moatasem, I left a few comments inline.

glbrntt · 2021-11-24T12:56:37Z

README.md

@@ -17,6 +17,17 @@ all four gRPC API styles (Unary, Server Streaming, Client Streaming, and
 Bidirectional Streaming) and connections can be made either over secure (TLS) or
 insecure channels.

+
+## Homebrew (Easy Installation)


Since this is just another way of getting the plugins for protoc, could you move this into the "Getting the protoc plugins" section? I don't think it needs its own subsection either; it just needs a note to say that the plugins are available from homebrew and can be installed with brew install grpc-swift (swift-protobuf is installed as a dependency of grpc-swift)

Ok Sure
I will move it there "Getting the protoc plugins" section
Thanks

glbrntt · 2021-11-24T12:57:11Z

README.md

@@ -17,6 +17,17 @@ all four gRPC API styles (Unary, Server Streaming, Client Streaming, and
 Bidirectional Streaming) and connections can be made either over secure (TLS) or
 insecure channels.

+
+## Homebrew (Easy Installation)
+1. Installing Swift-Protobuf : 


Suggested change

1. Installing Swift-Protobuf :

1. Installing Swift Protobuf:

glbrntt · 2021-11-24T12:57:43Z

README.md

+```bash
+    $ brew install swift-protobuf
+```
+2. Installing GRPC-Swift : 


Suggested change

2. Installing GRPC-Swift :

2. Installing gRPC Swift:

glbrntt · 2021-11-24T13:09:27Z

README.md

+### Easy Files Generation: 
+
+When you have *.proto files in "Data/gRPC_Schema" in Xcode directory
+You can add Build Phase Script for automatic generation for swift fils  *.pb.swift and *.grpc.swift files on the same directory "Data/gRPC_Schema"
+
+```bash
+cd "${SRCROOT}/${TARGET_NAME}/Data/gRPC_Schema"
+currentPath = "${SRCROOT}/${TARGET_NAME}/Data/gRPC_Schema"
+for i in $(ls | egrep '\.proto$'); 
+    do echo "$i";
+    protoc "$i" \
+             --swift_out=Visibility=Public:. \
+             --grpc-swift_out=Visibility=Public,Client=true,Server=false:.;
+
+done; 
+```


I don't think we should include this section: build phase scripts aren't an unknown feature and the script itself is fairly simple. It's also highly likely to be different for different folks (different paths to .proto files, different plugin options and so on).

Ok Great
I think it depends on your usage and it's not complicated to build
I will remove it
Thanks

2) [MOD] Moving Homebrew Installation to "Getting the `protoc` Plugins" section

glbrntt · 2021-11-24T14:05:06Z

README.md

@@ -131,6 +133,17 @@ the following line to your `Podfile`:
    pod 'gRPC-Swift-Plugins'
 ```

+Homebrew (Easy Installation)
+The plugins are available from homebrew and can be installed with :


Suggested change

The plugins are available from homebrew and can be installed with :

The plugins are available from [homebrew](https://brew.sh) and can be installed with:

glbrntt · 2021-11-24T14:08:25Z

README.md

+1. Installing Swift Protobuf : (swift-protobuf is installed as a dependency of grpc-swift)
+```bash
+    $ brew install swift-protobuf
+```
+2. Installing gRPC Swift : 


Suggested change

1. Installing Swift Protobuf : (swift-protobuf is installed as a dependency of grpc-swift)

```bash

$ brew install swift-protobuf

```

2. Installing gRPC Swift :

glbrntt · 2021-11-24T14:09:35Z

README.md

+```
+2. Installing gRPC Swift : 
+```bash
+    $ brew install grpc-swift


Suggested change

$ brew install grpc-swift

$ brew install swift-protobuf grpc-swift

glbrntt · 2021-11-24T14:10:31Z

README.md

@@ -131,6 +131,18 @@ the following line to your `Podfile`:
    pod 'gRPC-Swift-Plugins'
 ```

+#### Homebrew (Easy Installation) :


Suggested change

#### Homebrew (Easy Installation) :

#### Homebrew

glbrntt · 2021-11-24T14:28:51Z

README.md

@@ -131,6 +131,14 @@ the following line to your `Podfile`:
    pod 'gRPC-Swift-Plugins'
 ```

+#### Homebrew :


Suggested change

#### Homebrew :

#### Homebrew

glbrntt · 2021-11-24T14:29:12Z

README.md

+#### Homebrew :
+
+The plugins are available from [homebrew](https://brew.sh) and can be installed with:
+1. Installing Swift Protobuf / gRPC Swift : 


Suggested change

1. Installing Swift Protobuf / gRPC Swift :

glbrntt · 2021-11-24T14:34:38Z

README.md

+```bash
+    $ brew install swift-protobuf grpc-swift
+```
+
 The plugins are available in the `Pods/gRPC-Swift-Plugins/` folder afterwards.


Ah, this line has escaped from the section above, it should come before the #### Homebrew line.

Yup
You are right!

Done

glbrntt

Great, thank you!

El-Moatasem added 2 commits November 24, 2021 13:39

[ADD] Adding Homebrew Easy Installations for "Swift-Protobuf" and "GR…

6d7bfc1

…PC-Swift" on Mac OS Machine

[ADD] Adding Easy File Generations Using Build Phase Script

7a91688

glbrntt requested changes Nov 24, 2021

View reviewed changes

glbrntt added the semver/none No version bump required. label Nov 24, 2021

El-Moatasem added 6 commits November 24, 2021 15:53

1) [MOD] Removing Files Generation Script

6879295

2) [MOD] Moving Homebrew Installation to "Getting the `protoc` Plugins" section

[MOD] Modifying README.md

fda519d

[MOD] Modifying README.md

20b1719

[MOD] Modifying README.md

7b70e43

[MOD] Modifying README.md

90906bd

[MOD] Modifying README.md

34cf0db

glbrntt reviewed Nov 24, 2021

View reviewed changes

[MOD] Modifying README.md

73a2c49

glbrntt reviewed Nov 24, 2021

View reviewed changes

[MOD] Modifying README.md

6903d78

glbrntt reviewed Nov 24, 2021

View reviewed changes

[MOD] Modifying README.md

23201c6

glbrntt approved these changes Nov 24, 2021

View reviewed changes

glbrntt merged commit f1323a2 into grpc:main Nov 24, 2021

bimawa pushed a commit to StreamLayer/grpc-swift that referenced this pull request Dec 16, 2021

Add instructions to install plugins via Homebrew (grpc#1318)

b3e0448

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

gPRC swift protobuf easy installation + easy file generataions #1318

gPRC swift protobuf easy installation + easy file generataions #1318

El-Moatasem commented Nov 24, 2021

linux-foundation-easycla bot commented Nov 24, 2021 •

edited

Loading

glbrntt left a comment

glbrntt Nov 24, 2021

El-Moatasem Nov 24, 2021

glbrntt Nov 24, 2021

El-Moatasem Nov 24, 2021

El-Moatasem Nov 24, 2021

glbrntt Nov 24, 2021

El-Moatasem Nov 24, 2021

El-Moatasem Nov 24, 2021

glbrntt Nov 24, 2021

El-Moatasem Nov 24, 2021

glbrntt Nov 24, 2021

El-Moatasem Nov 24, 2021

glbrntt Nov 24, 2021

El-Moatasem Nov 24, 2021

glbrntt Nov 24, 2021

El-Moatasem Nov 24, 2021

glbrntt Nov 24, 2021

El-Moatasem Nov 24, 2021

glbrntt Nov 24, 2021

El-Moatasem Nov 24, 2021

glbrntt Nov 24, 2021

El-Moatasem Nov 24, 2021

glbrntt Nov 24, 2021

El-Moatasem Nov 24, 2021

glbrntt left a comment

	The plugins are available from homebrew and can be installed with :
	The plugins are available from [homebrew](https://brew.sh) and can be installed with:

	$ brew install grpc-swift
	$ brew install swift-protobuf grpc-swift

gPRC swift protobuf easy installation + easy file generataions #1318

gPRC swift protobuf easy installation + easy file generataions #1318

Conversation

El-Moatasem commented Nov 24, 2021

linux-foundation-easycla bot commented Nov 24, 2021 • edited Loading

glbrntt left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

glbrntt left a comment

Choose a reason for hiding this comment

linux-foundation-easycla bot commented Nov 24, 2021 •

edited

Loading