Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type 'Foo' does not conform to protocol '_MessageImplementationBase' #302

Closed
AaronTriplett opened this issue Sep 1, 2018 · 4 comments
Closed

Comments

@AaronTriplett
Copy link

AaronTriplett commented Sep 1, 2018

Extensions for each message type in my generated pb.swift files do not conform to the _MessageImplementationBase protocol. Looks like they are missing the _protobuf_generated_isEqualTo function.

screen shot 2018-08-31 at 11 52 20 pm

I am generating these outside of my project using the following:
protoc 3.5.1
protoc-gen-swift 1.1.1
protoc-gen-swiftgrpc master

@AaronTriplett
Copy link
Author

Looks like this issue is caused due to me building the protoc-gen-swift and protoc-gen-swiftgrpc plugins using the master branch, which includes swift-protobuf 1.1.1. However, when including the SwiftGRPC dependency in my podspec, it grabs the latest 0.5.1 release which uses swift-protobuf 1.0.3.

Swift-protobuf 1.1.1 updates the _MessageImplementationBase protocol to include a default implementation extension for the _protobuf_generated_isEqualTo function. Using plugins built from master, the method doesn't get added to my generated message types because the SwiftGRPC (0.5.1) dependency in my podspec doesn't have the default implementation included in its swift-protobuf 1.0.3 dependency.

Building the plugins from 0.5.1 resolves my issues. Any chance a new release will be cut soon that includes swift-protobuf 1.1.1?

@MrMage
Copy link
Collaborator

MrMage commented Sep 3, 2018

Thanks for the heads-up! Given that this is a breaking change, we should indeed cut a new release. I've created #303 now. Once that has been approved by @timburks, I can merge it and update the CocoaPods repo.

@AaronTriplett
Copy link
Author

Great 👍

@MrMage
Copy link
Collaborator

MrMage commented Sep 4, 2018

I have pushed 0.6.0 to CocoaPods now; please let me know if the issue occurs again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants