grpc-js: Use a more structured representation of URIs internally #1364
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is a result of a few things:
The new
parseUri
function is based ongrpc_uri_parse
, except that I don't handle query parameters or fragments because they don't seem to be useful anywhere.The new
splitHostPort
function is based onDoSplitHostPort
.One major thing to note: I realized after implementing this that for a target without a real scheme like
localhost:80
, a completely valid parsing of that target could havescheme='localhost'
andpath='80'
, but that is not useful. So, if a target has an unknown scheme, the resolver uses the whole target as the path.This fixes #1359.