Skip to content

Commit

Permalink
grpc-js: do not pass target name override to proxy
Browse files Browse the repository at this point in the history
  • Loading branch information
mrfelton committed Apr 18, 2020
1 parent ddb968e commit a3a7534
Showing 1 changed file with 6 additions and 15 deletions.
21 changes: 6 additions & 15 deletions packages/grpc-js/src/subchannel.ts
Original file line number Diff line number Diff line change
Expand Up @@ -416,21 +416,12 @@ export class Subchannel {
this.credentials._getConnectionOptions() || {};

if ('secureContext' in connectionOptions) {
// If provided, the value of grpc.ssl_target_name_override should be used
// to override the target hostname when checking server identity.
// This option is used for testing only.
if (this.options['grpc.ssl_target_name_override']) {
const sslTargetNameOverride = this.options[
'grpc.ssl_target_name_override'
]!;
connectionOptions.checkServerIdentity = (
host: string,
cert: PeerCertificate
): Error | undefined => {
return checkServerIdentity(sslTargetNameOverride, cert);
};
connectionOptions.servername = sslTargetNameOverride;
}
connectionOptions.checkServerIdentity = (
host: string,
cert: PeerCertificate
): Error | undefined => {
return checkServerIdentity(host, cert);
};
}

getProxiedConnection(this.subchannelAddress, this.options, connectionOptions).then(
Expand Down

0 comments on commit a3a7534

Please sign in to comment.