README.md:Improve instructions #9974
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can use a prefix like "README.md: Improve instructions". Generally the file/folder is a good start of a prefix. |
larry-safran
changed the title
temawi
approved these changes
Mar 24, 2023
ejona86
reviewed
Mar 27, 2023
| @@ -114,6 +115,10 @@ Tagging the Release | |||
| $ ${EDITOR:-nano -w} README.md | |||
| $ ${EDITOR:-nano -w} documentation/android-channel-builder.md | |||
| $ ${EDITOR:-nano -w} cronet/README.md | |||
| # Bump protobuf plugin version if needed in README.md and multiple examples | |||
There was a problem hiding this comment.
This should be done in the PR that changes the versions. The comment also mentions "README.md" but this edit line doesn't reference any README.md
| $ git checkout -b bump-readme master | ||
| $ git cherry-pick v$MAJOR.$MINOR.$PATCH^ | ||
| $ git push |
There was a problem hiding this comment.
This won't work, right? You need something more like git push --set-upstream origin bump-readme
There was a problem hiding this comment.
I've got autoSetupRemote set to true on pushes, so it works for me, but good point that it should be setup for the default case.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clarify some areas where I misstepped on my first time doing a full release.