-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
alts: Make GoogleDefaultChannelCredentials take a CallCredentials #8548
Merged
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
6a8ad79
alts: Make ComputeEngineChannelCredentials take a CallCredentials as …
mohanli-ml 189dfce
alts: Make ComputeEngineChannelCredentials take a CallCredentials
mohanli-ml a3f4724
alts: Make ComputeEngineChannelCredentials take a CallCredentials
mohanli-ml 5f5abaf
Merge branch 'master' into compute-engine-creds
mohanli-ml 2893db7
alts: Make ComputeEngineChannelCredentials take a CallCredentials
mohanli-ml 5153201
alts: Make ComputeEngineChannelCredentials take a CallCredentials
mohanli-ml 0d1fd71
alts: Make ComputeEngineChannelCredentials take a CallCredentials
mohanli-ml b229d4f
alts: Make GoogleDefaultChannelCredentials take a CallCredentials
mohanli-ml 8cb0153
alts: Make GoogleDefaultChannelCredentials take a CallCredentials
mohanli-ml 045743f
alts: Make GoogleDefaultChannelCredentials take a CallCredentials
mohanli-ml 0d6658e
Merge branch 'master' into compute-engine-creds
mohanli-ml 6b7d3ca
alts: Make GoogleDefaultChannelCredentials take a CallCredentials
mohanli-ml File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -44,30 +44,65 @@ private GoogleDefaultChannelCredentials() {} | |
* as fallback. | ||
*/ | ||
public static ChannelCredentials create() { | ||
ChannelCredentials nettyCredentials = | ||
InternalNettyChannelCredentials.create(createClientFactory()); | ||
CallCredentials callCredentials; | ||
try { | ||
callCredentials = MoreCallCredentials.from(GoogleCredentials.getApplicationDefault()); | ||
} catch (IOException e) { | ||
callCredentials = new FailingCallCredentials( | ||
Status.UNAUTHENTICATED | ||
.withDescription("Failed to get Google default credentials") | ||
.withCause(e)); | ||
} | ||
return CompositeChannelCredentials.create(nettyCredentials, callCredentials); | ||
return newBuilder().build(); | ||
} | ||
|
||
private static InternalProtocolNegotiator.ClientFactory createClientFactory() { | ||
SslContext sslContext; | ||
try { | ||
sslContext = GrpcSslContexts.forClient().build(); | ||
} catch (SSLException e) { | ||
throw new RuntimeException(e); | ||
/** | ||
* Returns a new instance of {@link Builder}. | ||
* | ||
* @since 1.42.0 | ||
*/ | ||
public static Builder newBuilder() { | ||
return new Builder(); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Declare There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. done |
||
} | ||
|
||
/** | ||
* Builder for {@link GoogleDefaultChannelCredentials} instances. | ||
* | ||
* @since 1.42.0 | ||
*/ | ||
public static final class Builder { | ||
private CallCredentials callCredentials; | ||
|
||
private Builder() {} | ||
|
||
/** Constructs GoogleDefaultChannelCredentials with a given call credential. */ | ||
public Builder callCredentials(CallCredentials callCreds) { | ||
callCredentials = callCreds; | ||
return this; | ||
} | ||
|
||
/** Builds a GoogleDefaultChannelCredentials instance. */ | ||
public ChannelCredentials build() { | ||
ChannelCredentials nettyCredentials = | ||
InternalNettyChannelCredentials.create(createClientFactory()); | ||
if (callCredentials != null) { | ||
return CompositeChannelCredentials.create(nettyCredentials, callCredentials); | ||
} | ||
CallCredentials callCreds; | ||
try { | ||
callCreds = MoreCallCredentials.from(GoogleCredentials.getApplicationDefault()); | ||
} catch (IOException e) { | ||
callCreds = | ||
new FailingCallCredentials( | ||
Status.UNAUTHENTICATED | ||
.withDescription("Failed to get Google default credentials") | ||
.withCause(e)); | ||
} | ||
return CompositeChannelCredentials.create(nettyCredentials, callCreds); | ||
} | ||
|
||
private static InternalProtocolNegotiator.ClientFactory createClientFactory() { | ||
SslContext sslContext; | ||
try { | ||
sslContext = GrpcSslContexts.forClient().build(); | ||
} catch (SSLException e) { | ||
throw new RuntimeException(e); | ||
} | ||
return new GoogleDefaultProtocolNegotiatorFactory( | ||
/* targetServiceAccounts= */ ImmutableList.<String>of(), | ||
SharedResourcePool.forResource(HandshakerServiceChannel.SHARED_HANDSHAKER_CHANNEL), | ||
sslContext); | ||
} | ||
return new GoogleDefaultProtocolNegotiatorFactory( | ||
/* targetServiceAccounts= */ ImmutableList.<String>of(), | ||
SharedResourcePool.forResource(HandshakerServiceChannel.SHARED_HANDSHAKER_CHANNEL), | ||
sslContext); | ||
} | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: Add javadoc and
@since 1.42.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done