Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RELEASING.md: Include commit hash in shortlog #10716

Merged
merged 1 commit into from
Nov 30, 2023

Conversation

ejona86
Copy link
Member

@ejona86 ejona86 commented Nov 28, 2023

This removes the benefit of including the PR number in the title without also requiring using github APIs to query the PR number. It still provides the same details about the change, and indirectly links to the PR if the user wants to see the review.

This removes the benefit of including the PR number in the title without
also requiring using github APIs to query the PR number. It still
provides the same details about the change, and indirectly links to the
PR if the user wants to see the review.
@ejona86 ejona86 requested a review from sergiitk November 28, 2023 18:13
Copy link
Member

@sergiitk sergiitk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect.

Also verified that this works (wasn't sure if my git log customization would interfere). Everything works.

@sergiitk sergiitk merged commit d62334e into grpc:master Nov 30, 2023
@ejona86 ejona86 deleted the release-notes-incl-commit branch November 30, 2023 01:15
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants