Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #7664 into v1.66.x #7684

Merged
merged 1 commit into from
Sep 30, 2024

Conversation

purnesh42H
Copy link
Contributor

@purnesh42H purnesh42H commented Sep 30, 2024

Original PR: #7664

RELEASE NOTES:

  • xds/server: Fix xDS Server memory leak

Copy link

codecov bot commented Sep 30, 2024

Codecov Report

Attention: Patch coverage is 93.75000% with 1 line in your changes missing coverage. Please review.

Project coverage is 81.85%. Comparing base (bcbf356) to head (dc0c185).
Report is 1 commits behind head on v1.66.x.

Files with missing lines Patch % Lines
xds/internal/server/listener_wrapper.go 93.33% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           v1.66.x    #7684      +/-   ##
===========================================
- Coverage    81.95%   81.85%   -0.10%     
===========================================
  Files          361      361              
  Lines        27858    27862       +4     
===========================================
- Hits         22830    22807      -23     
- Misses        3841     3855      +14     
- Partials      1187     1200      +13     
Files with missing lines Coverage Δ
xds/internal/server/conn_wrapper.go 77.04% <100.00%> (-4.62%) ⬇️
xds/internal/server/listener_wrapper.go 79.01% <93.33%> (+0.39%) ⬆️

... and 21 files with indirect coverage changes

@purnesh42H purnesh42H added the Type: Meta Github repo, process, etc label Sep 30, 2024
@purnesh42H purnesh42H added this to the 1.66 Release milestone Sep 30, 2024
@arjan-bal
Copy link
Contributor

Though it's not documented, the title for cherry-pick PRs is usually of the form: "Cherry-pick #7664 into v1.66.x"

@arjan-bal arjan-bal assigned purnesh42H and unassigned arjan-bal Sep 30, 2024
@purnesh42H purnesh42H changed the title xds/server: Fix xDS Server leak (#7664) Cherry-pick #7664 into v1.66.x Sep 30, 2024
@purnesh42H purnesh42H assigned arjan-bal and unassigned purnesh42H Sep 30, 2024
@arjan-bal arjan-bal added Type: Bug and removed Type: Meta Github repo, process, etc labels Sep 30, 2024
@arjan-bal arjan-bal assigned purnesh42H and unassigned arjan-bal Sep 30, 2024
@purnesh42H purnesh42H merged commit efb28a4 into grpc:v1.66.x Sep 30, 2024
12 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants